Skip to content

[FLINK-37406] Add support for structured YAML config in FlinkDeployment CRD #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 21, 2025
Merged

[FLINK-37406] Add support for structured YAML config in FlinkDeployment CRD #1013

merged 19 commits into from
Aug 21, 2025

Conversation

@csviri
Copy link
Contributor

@csviri csviri commented Aug 18, 2025 •
edited
Loading

What is the purpose of the change

Allow to set flinkConfiguration as yaml, not just key/value pairs.

Brief change log

  • changes CRD to allow set flinkConfiguration as yaml not just key/value pairs
  • changed type of AbstractFlinkSpec.flinkConfiguration it now accepts yaml.
  • adjusted CRD checker to allow such changes

Verifying this change

  • adjusted e2e tests to the new format
  • added test for CRD migration

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: yes
  • Core observer or reconciler logic that is regularly executed: yes

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

csviri added 6 commits August 18, 2025 09:09
@csviri
[FLINK-37406] Add support for structured YAML config in FlinkDeployme…
b90676a 
…nt CRD

Signed-off-by: Attila Mészáros <[email protected]>
@csviri
diff, test fixes
d9da3fb 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
wip
ddf83c0 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
fix
03614b3 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
wip
dfbbb33 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
wip
38eda4c 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri changed the title Add support for structured YAML config in FlinkDeployment CRD [WIP][FLINK-37406] Add support for structured YAML config in FlinkDeployment CRD Aug 18, 2025
@csviri csviri mentioned this pull request Aug 18, 2025
Closed
@csviri
unit tests
a9ee837 
Signed-off-by: Attila Mészáros <[email protected]>
csviri added 4 commits August 19, 2025 11:34
@csviri
CRD update in helm chart, add migration test
6a89134 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
Config
e4a4d24 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
naming
9fc5a8a 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
cleanup
3ac4339 
Signed-off-by: Attila Mészáros <[email protected]>
csviri added 4 commits August 20, 2025 12:26
@csviri
improvements + cleanup
381951b 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
naming
3829654 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
remove empty lines
447ea75 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
crd checker and changed e2e test
17030be 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri marked this pull request as ready for review August 20, 2025 11:59
@csviri csviri requested a review from gyfora August 20, 2025 11:59
@csviri csviri changed the title [WIP][FLINK-37406] Add support for structured YAML config in FlinkDeployment CRD [FLINK-37406] Add support for structured YAML config in FlinkDeployment CRD Aug 20, 2025
csviri added 3 commits August 20, 2025 14:29
@csviri
javadocs fix
43c2462 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
add javadoc for ConfigObjectNode
1494b10 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
use proper values not string in yaml
9626931 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri mentioned this pull request Aug 20, 2025
Merged
gyfora
gyfora reviewed Aug 21, 2025
View reviewed changes
flink-kubernetes-operator-api/pom.xml Outdated

<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
Copy link
Contributor

@gyfora gyfora Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is now added twice if I see correctly

Copy link
Contributor Author

@csviri csviri Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch fixed

gyfora
gyfora approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@gyfora gyfora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the single duplicated test dependency :)

@csviri
fix duplicate dependency
c74e56b 
Signed-off-by: Attila Mészáros <[email protected]>
@gyfora gyfora merged commit 37e3c84 into apache:main Aug 21, 2025
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyfora gyfora gyfora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csviri @gyfora