[FLINK-36264] Fix can not setup other values for parameter rest-service.exposed.type
#883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyuzhi459
force-pushed
the
36264/fix_customize_rest-service-exposed-type
branch
from
458aa09 to
9d9d42c
Compare
mateczagany
reviewed
Sep 28, 2024
| protected FlinkConfigBuilder applyIngressDomain() { | ||
| // Web UI | ||
| if (spec.getIngress() != null) { | ||
| if (spec.getIngress() != null |
There was a problem hiding this comment.
I think we can get rid of applyIngressDomain() altogether, this default configuration is already applied in method applyFlinkConfiguration(), where it's only set if the configuration is not yet set by the user.
There was a problem hiding this comment.
Thanks, I have removed applyIngressDomain() and tested it works as expected
chenyuzhi459
force-pushed
the
36264/fix_customize_rest-service-exposed-type
branch
from
a024636 to
6fd4d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix can not setup other values for parameter
rest-service.exposed.typewhen using ingressBrief change log
Only if using ingress and the
rest-service.exposed.type=null, operator will setup asClusterIpwhenVerifying this change
Unit tests + manual verification
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: (no)Documentation