[FLINK-38047] Bump cert-manager from v1.8.2 to v1.18.2 #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the cert-manager version used in the Flink Kubernetes Operator from v1.8.2 to v1.18.2. The changes include: - Updated cert-manager in e2e-tests/cert-manager.yaml to v1.18.2 (source: https://github.com/jetstack/cert-manager/releases/download/v1.18.2/cert-manager.yaml) - Updated documentation references in helm.md and quick-start.md to use the new cert-manager version
rmetzger
reviewed
Jul 9, 2025
docs/content/docs/operations/helm.md
Outdated
| In order to use the webhooks in the operator, you must install the cert-manager on the Kubernetes cluster: | ||
| ``` | ||
| kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.8.2/cert-manager.yaml | ||
| kubectl create -f https://github.com/jetstack/cert-manager/releases/download/v1.18.2/cert-manager.yaml |
There was a problem hiding this comment.
Why did you switch from apply to create?
Doesn't it make more sense to apply, to make sure we update to the latest version, if something is running already?
There was a problem hiding this comment.
also the chinese docs version is using apply. They should be aligned.
Contributor
Author
There was a problem hiding this comment.
My bad. The quick-start docs use create. 🤔 Should we update them too?
There was a problem hiding this comment.
The cert-manager docs use apply so let's use that everywhere: https://cert-manager.io/docs/installation/
|
Thanks, I'll merge this once CI is green! |
rmetzger
approved these changes
Jul 10, 2025
Contributor
Author
Thanks, @rmetzger ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR updates the cert-manager version used in the Flink Kubernetes Operator from v1.8.2 to v1.18.2.
Brief change log
Verifying this change
This change is already covered by existing tests - e2e setup. Manual validation results are included in FLINK-38047.
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: (no)Documentation