Skip to content

[FLINK-38047] Bump cert-manager from v1.8.2 to v1.18.2 #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

[FLINK-38047] Bump cert-manager from v1.8.2 to v1.18.2 #992

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51bb70b
[FLINK-38047] Bump cert-manager from v1.8.2 to v1.18.2
kumar-mallikarjuna Jul 9, 2025
2d50199
[FLINK-38047] Switch `kubectl create` with `kubectl apply`
kumar-mallikarjuna Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content.zh/docs/operations/helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ __Notice__: The pod resources should be set as your workload in different enviro

In order to use the webhooks in the operator, you must install the cert-manager on the Kubernetes cluster:
```
kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.8.2/cert-manager.yaml
kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.18.2/cert-manager.yaml
```

The webhooks can be disabled during helm install by passing the `--set webhook.create=false` parameter or editing the `values.yaml` directly.
Expand Down
2 changes: 1 addition & 1 deletion docs/content.zh/docs/try-flink-kubernetes-operator/quick-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ We also recommend [k9s](https://k9scli.io/) as GUI for kubernetes, but it is opt

Install the certificate manager on your Kubernetes cluster to enable adding the webhook component (only needed once per Kubernetes cluster):
```bash
kubectl create -f https://github.com/jetstack/cert-manager/releases/download/v1.8.2/cert-manager.yaml
kubectl create -f https://github.com/jetstack/cert-manager/releases/download/v1.18.2/cert-manager.yaml
```

{{< hint info >}}
Expand Down
2 changes: 1 addition & 1 deletion docs/content/docs/operations/helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ __Notice__: The pod resources should be set as your workload in different enviro

In order to use the webhooks in the operator, you must install the cert-manager on the Kubernetes cluster:
```
kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.8.2/cert-manager.yaml
kubectl create -f https://github.com/jetstack/cert-manager/releases/download/v1.18.2/cert-manager.yaml
Copy link

@rmetzger rmetzger Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you switch from apply to create?
Doesn't it make more sense to apply, to make sure we update to the latest version, if something is running already?

Copy link

@rmetzger rmetzger Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the chinese docs version is using apply. They should be aligned.

Copy link
Contributor Author

@kumar-mallikarjuna kumar-mallikarjuna Jul 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. The quick-start docs use create. 🤔 Should we update them too?

Copy link

@rmetzger rmetzger Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cert-manager docs use apply so let's use that everywhere: https://cert-manager.io/docs/installation/

Copy link
Contributor Author

@kumar-mallikarjuna kumar-mallikarjuna Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

```

The webhooks can be disabled during helm install by passing the `--set webhook.create=false` parameter or editing the `values.yaml` directly.
Expand Down
2 changes: 1 addition & 1 deletion docs/content/docs/try-flink-kubernetes-operator/quick-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ We also recommend [k9s](https://k9scli.io/) as GUI for kubernetes, but it is opt

Install the certificate manager on your Kubernetes cluster to enable adding the webhook component (only needed once per Kubernetes cluster):
```bash
kubectl create -f https://github.com/jetstack/cert-manager/releases/download/v1.8.2/cert-manager.yaml
kubectl create -f https://github.com/jetstack/cert-manager/releases/download/v1.18.2/cert-manager.yaml
```

{{< hint info >}}
Expand Down
Loading
Loading