Skip to content

Conversation

Poorvankbhatia
Copy link
Contributor

What is the purpose of the change

This pull request migrates TypeFillTest from the deprecated SourceFunction API to the new Source V2 API

Brief change log

  • TypeFillTest.java: Replaced TestSource extends SourceFunction with NoopSource implements Source<T, SourceSplit, Void> for type inference testing

Verifying this change

This change is already covered by existing tests:

TypeFillTest.java:

  • All type inference validation tests continue to pass, verifying InvalidTypesException is thrown for sources without explicit type information
  • Tests confirm .returns() method properly resolves type information for generic sources

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@Poorvankbhatia Poorvankbhatia changed the title [FLINK-32695] Moved TestSource to SourceV2 [FLINK-32695] Moved TestSource in TypeFillTest to SourceV2 Jul 31, 2025
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 31, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@fapaul fapaul self-requested a review August 5, 2025 09:17
@Poorvankbhatia Poorvankbhatia force-pushed the FLINK-32695-TypeFillTest-Migration-Source-V2 branch from 6ab4030 to b9b41bc Compare August 20, 2025 09:05
@Poorvankbhatia
Copy link
Contributor Author

@fapaul Rebased Master and now using Test source utility. PTAL :)

Copy link
Contributor

@fapaul fapaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the branch locally and ran the test successfully the CI failure is unrelated.

@fapaul fapaul merged commit a516014 into apache:master Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants