Skip to content

[FLINK-32695] Moved TestSource in TypeFillTest to SourceV2 #26854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

[FLINK-32695] Moved TestSource in TypeFillTest to SourceV2 #26854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions flink-runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ under the License.
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-test-utils-connector</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-queryable-state-client-java</artifactId>
Expand Down
24 changes: 12 additions & 12 deletions flink-runtime/src/test/java/org/apache/flink/streaming/api/TypeFillTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.flink.streaming.api;

import org.apache.flink.api.common.eventtime.WatermarkStrategy;
import org.apache.flink.api.common.functions.FlatMapFunction;
import org.apache.flink.api.common.functions.InvalidTypesException;
import org.apache.flink.api.common.functions.MapFunction;
Expand All @@ -30,7 +31,7 @@
import org.apache.flink.streaming.api.functions.co.CoFlatMapFunction;
import org.apache.flink.streaming.api.functions.co.CoMapFunction;
import org.apache.flink.streaming.api.functions.co.ProcessJoinFunction;
import org.apache.flink.streaming.api.functions.source.legacy.SourceFunction;
import org.apache.flink.test.util.source.AbstractTestSource;
import org.apache.flink.util.Collector;

import org.junit.jupiter.api.Test;
Expand All @@ -51,7 +52,13 @@ class TypeFillTest {
void test() {
StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();

assertThatThrownBy(() -> env.addSource(new TestSource<Integer>()).print())
assertThatThrownBy(
() ->
env.fromSource(
new TestSource<Integer>(),
WatermarkStrategy.noWatermarks(),
"")
.print())
.isInstanceOf(InvalidTypesException.class);

DataStream<Long> source = env.fromSequence(1, 10);
Expand Down Expand Up @@ -110,7 +117,8 @@ void test() {
.print())
.isInstanceOf(InvalidTypesException.class);

env.addSource(new TestSource<Integer>()).returns(Integer.class);
env.fromSource(new TestSource<Integer>(), WatermarkStrategy.noWatermarks(), "")
.returns(Integer.class);
source.map(new TestMap<Long, Long>()).returns(Long.class).print();
source.flatMap(new TestFlatMap<Long, Long>()).returns(new TypeHint<Long>() {}).print();
source.connect(source)
Expand Down Expand Up @@ -157,15 +165,7 @@ public String map(Long value) throws Exception {
.isInstanceOf(IllegalStateException.class);
}

private static class TestSource<T> implements SourceFunction<T> {
private static final long serialVersionUID = 1L;

@Override
public void run(SourceContext<T> ctx) throws Exception {}

@Override
public void cancel() {}
}
private static class TestSource<T> extends AbstractTestSource<T> {}

private static class TestMap<T, O> implements MapFunction<T, O> {
@Override
Expand Down