commons-logging 1.3.5

[JinwooHwang]

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

• Has your PR been rebased against the latest commit within the target branch (typically develop)?

• Is your initial contribution a single, squashed commit?

• Does gradlew build run cleanly?

• Have you written or updated unit tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[raboof]

I'm generally in favor of this change, but I'm reluctant to approve it because the 'develop / integrationTest' and 'develop / acceptanceTest' tests are failing.

The fact that those tests are failing is not your fault: they are already failing on master. These failures are tracked in the bug tracker as https://issues.apache.org/jira/browse/GEODE-10458 and https://issues.apache.org/jira/browse/GEODE-10459 .

If after analysis it appears that it is too complicated to fix those tests, I suppose we could disable those specific tests (while ideally keeping any other tests in those jobs) and leave the issues open to revisit re-enabling them again later. Would you have a chance to look into that?

[JinwooHwang]

Thank you for your feedback, @raboof. Could you please take a look at 9d736a9 to see if it takes care of https://issues.apache.org/jira/browse/GEODE-10458 ?

[raboof]

Thank you for your feedback, @raboof. Could you please take a look at 9d736a9 to see if it takes care of https://issues.apache.org/jira/browse/GEODE-10458 ?

When you open that commit page, near the top you see "Commit 9d736a9, JinwooHwang-SAS authored 16 hours ago . x 14 / 16 . Verified". If you click the x 14 / 16, you see that develop / integratonTest still fails for that commit.

If you click on 'Details' next to develop / integratonTest, the logs indeed reveal the AnalyzeCoreSerializablesIntegrationTest / testSerializables mentioned in https://issues.apache.org/jira/browse/GEODE-10458 is now fixed - congratulations! It would have been nice to mention GEODE-10458 in the #7915 commit and pull request. I've updated the PR title for you.

I see develop / integratonTest is now green on the main branch, awesome!

It would be super cool if we could also make develop / acceptanceTest green, but if that's too complicated then perhaps we can skip it instead

[JinwooHwang]

Thank you @raboof for the thoughtful follow-up and for updating the PR title to include GEODE-10458—much appreciated. I'm glad to hear the integration test is now passing and that the fix is confirmed. I agree it would have been ideal to reference the JIRA ticket directly in the commit; I’ll be more mindful of that going forward. Regarding the acceptance test, could you please let me know how to access the build machine to investigate whether Local Docker Compose is on the PATH? That would help me to assess feasibility more accurately. Are you more comfortable with approving the merge at this point?

[raboof]

Regarding the acceptance test, could you please let me know how to access the build machine to investigate whether Local Docker Compose is on the PATH?

The CI is running on GitHub Actions, so there is no access to the build machine, it is completely driven by .github/workflows.

Are you more comfortable with approving the merge at this point?

Now that the main branch is green after #7916 I'm confident any regressions caused by the update will be noticed, so I'll merge this.

[JinwooHwang]

Thank you very much @raboof