Update Project dependencies and Publishing #1873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `grails-datastore-gorm` module does not require an `api` dependency on `grails-core`. This change removes the unnecessary dependency to align with the module's actual requirements and prevent potential issues.
These tasks were missing after the migration to the Grails Publish Gradle Plugin. They are usually added by the Grails Plugin Gradle Plugin, but it is not used in this project. Using `java.withSourcesJar()` and `java.withJavadocJar()` is not compatible with this build.
matrei
changed the title
jdaugherty
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grails-datastore-gormmodule does not require anapidependency ongrails-core. This change removes the unnecessary dependency to align with the module's actual requirements and prevent potential issues.The
sourcesandjavadocjars are also missing from the publication. This PR adds them explicitly.