Doc Combination & Upgrade Guide#1211
Merged
jdaugherty merged 7 commits intoapache:7.0.xfrom Mar 19, 2026
Merged
Conversation
matrei
approved these changes
Mar 18, 2026
Contributor
matrei
left a comment
matrei
left a comment
There was a problem hiding this comment.
There seems to be some duplicate heading ids now that the documentation is aggregated.
Should be an easy fix by prefixing the ids with the plugin like core-introduction.
WARNING: ../../../plugin-core/docs/src/docs/introduction.adoc: line 21: id assigned to section already in use: introductionThe index.adoc header links were hardcoded to Spring Security 4.0.x and Spring Framework 4.1.x. Replace with AsciiDoc attributes populated from the BOM-resolved version in docs/build.gradle. Also add a NOTE comment about configuration-time dependency resolution in the docs build. Assisted-by: Claude Code <Claude@Claude.ai>
Each plugin docs/build.gradle applied reproducible-config.gradle twice:
once at the top level and again inside an apply {} block left over from the
docs-config.gradle refactor.
Assisted-by: Claude Code <Claude@Claude.ai>
Assisted-by: Claude Code <Claude@Claude.ai>
jamesfredley
approved these changes
Mar 19, 2026
Contributor
jamesfredley
left a comment
jamesfredley
left a comment
There was a problem hiding this comment.
Some minor stuff in https://github.com/apache/grails-spring-security/pull/1212/commits if you want it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've taken the upgrade guide from: apache/grails-core#15476 and created a combined docs. I've also improved the styling of the root guide page.