-
Notifications
You must be signed in to change notification settings - Fork 70
chore: bump C++ standard to 23 #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Waiting apache/arrow#46998 to be resolved, but should be fine for review. |
|
This is no longer a draft, right? |
Yeah, I just make it ready for review. |
The commit includes apache/arrow#46912, which are resolve our frequent CI failures.
|
I just changed to a more recent arrow commit which contains the Apache Thrift update[1], which should fix our frequent CI failure. |
|
So should Besides, C++23 has resize_and_overwrite, allowing zero-cost buffer initialization |
Personally I think Result/Status are well-structured wrappers, but I'm glad to hear others' opinions.
Ah, I wasn't aware of this feature, could you suggest where it might be applied? I think we can adopt more C++23 features in future PRs, assuming compiler support. I tried using |
I think we need to update it to use Apache Arrow 21.0.0 once it is released. It is only a temporary state to pin to an unreleased version. |
Sure, will keep an eye on it. |
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, let's move!
No description provided.