feat: add find field (by name) support to NestedType #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartLinked
reviewed
Aug 27, 2025
HeartLinked
reviewed
Aug 27, 2025
wgtmac
requested changes
Aug 27, 2025
| iceberg::SchemaField field2(5, "bar", iceberg::string(), true); | ||
| iceberg::Schema schema({field1, field2}, 100); | ||
| }, | ||
| ::testing::ThrowsMessage<std::runtime_error>( |
Contributor
Author
There was a problem hiding this comment.
The logic for detecting duplicate IDs has been moved to GetFieldById. Didn’t we agree earlier that no exceptions would be thrown?
Contributor
Author
There was a problem hiding this comment.
For list's element and map's key, value, do we need to do the same processing? However, I think it's a bit strange to handle it in GetFieldByName(), they are easy, so I didn't change its exception-throwing form.
nullccxsy
force-pushed
the
type-find
branch
3 times, most recently
from
865c2eb to
0a2b037
Compare
wgtmac
reviewed
Aug 28, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Generally looks good. Left some nits.
HeartLinked
approved these changes
Aug 29, 2025
wgtmac
requested changes
Sep 1, 2025
Member
|
BTW, the PR title is broken... |
nullccxsy
changed the title
nullccxsy
changed the title
nullccxsy
changed the title
HuaHuaY
reviewed
Sep 2, 2025
HuaHuaY
reviewed
Sep 2, 2025
added 5 commits
September 2, 2025 14:04
… MapType
- Implemented case-insensitive GetFieldByName in NestedType subclasses.
- Added lazy initialization for maps in StructType
- Handled duplicate names/IDs with Status returns instead of throws.
- Streamlined the macro to reduce nesting and improve readability by using an inline if statement.
wgtmac
approved these changes
Sep 3, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
LGTM. Left some nits. Thanks for working on this!
wgtmac
approved these changes
Sep 3, 2025
Fokko
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… MapType