feat: implement manifest and manifest list writer adapter (cont'd) #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartLinked
reviewed
Sep 11, 2025
dongxiao1198
force-pushed
the
manifest_adapter_impl
branch
from
f79e978 to
478a6ea
Compare
wgtmac
reviewed
Sep 12, 2025
wgtmac
requested changes
Sep 23, 2025
dongxiao1198
force-pushed
the
manifest_adapter_impl
branch
from
bafed12 to
977466d
Compare
wgtmac
requested changes
Oct 10, 2025
src/iceberg/manifest_adapter.h
Outdated
| const std::shared_ptr<Schema>& schema() const { return manifest_schema_; } | ||
|
|
||
| protected: | ||
| virtual Result<std::shared_ptr<StructType>> GetManifestEntryStructType(); |
Member
There was a problem hiding this comment.
I think StructType is redundant.
src/iceberg/partition_spec.h
Outdated
| std::vector<PartitionField> fields_; | ||
| int32_t last_assigned_field_id_; | ||
| std::mutex mutex_; | ||
| std::shared_ptr<Schema> partition_schema_; |
dongxiao1198
force-pushed
the
manifest_adapter_impl
branch
from
96be403 to
ec65a69
Compare
1 parse v1v2v3 manifest schema in adapter 2 convert ManifestFile&ManifestEntry into ArrowArray 3 add e2e case
wgtmac
force-pushed
the
manifest_adapter_impl
branch
from
95f0342 to
6b31e28
Compare
wgtmac
changed the title
wgtmac
approved these changes
Oct 16, 2025
Member
|
Thanks @dongxiao1198 for working on this! I've resolved conflicts with some minor refactoring. |
gty404
pushed a commit
to gty404/iceberg-cpp
that referenced
this pull request
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 parse v1v2v3 manifest schema in adapter
2 convert ManifestFile&ManifestEntry into ArrowArray
3 add e2e case