-
Notifications
You must be signed in to change notification settings - Fork 70
chore: Align LICENSE and NOTICE with ASF policy #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jbonofre Could you help review this? |
|
@HeartLinked absolutely. Let me take a look. Happy to help 😃 |
|
The Imho, the
|
Thanks for your review! Actually, our project is distributed as a source package that users compile themselves. We do not copy source files from Following our discussion, I have now removed all related third-party license content from the file. Do you think this revised version is more accurate? @jbonofre |
jbonofre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's correct now. Thanks !
LICENSE
Outdated
| https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.cc | ||
| * checked_cast utility in src/iceberg/util/checked_cast.h. | ||
| * visit_type utility in src/iceberg/util/visit_type.h. | ||
| * Decimal128 implementation details in src/iceberg/util/decimal files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: cmake_modules/IcebergBuildUtils.cmake and cmake_modules/IcebergThirdpartyToolchain.cmake are also adapted from arrow-cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added these. :)
|
Thanks @HeartLinked for the follow up and thanks everyone for the review 🙌 |
Refines the LICENSE and NOTICE files to ensure full compliance with Apache Software Foundation (ASF) guidelines.https://infra.apache.org/licensing-howto.html
Simplify NOTICE File: Dependencies with permissive licenses (such as MIT, zlib, and Public Domain) have been removed from the NOTICE file. According to ASF policy, the copyright notices embedded within these types of licenses do not need to be duplicated in the project's NOTICE file.
Reformat LICENSE File: The appendix of the LICENSE file, which lists third-party dependencies, has been reformatted for clarity and consistency. The new style is based on the Apache Iceberg repository's LICENSE file. https://github.com/apache/iceberg/blob/main/LICENSE
Add cpr license for rest catalog.