feat: add config, error and validation for rest types #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartLinked
force-pushed
the
rest_test_refactor_my
branch
2 times, most recently
from
f1c8df0 to
35e5eaa
Compare
HeartLinked
force-pushed
the
rest_test_refactor_my
branch
from
35e5eaa to
b6dbfb9
Compare
wgtmac
reviewed
Nov 5, 2025
HeartLinked
force-pushed
the
rest_test_refactor_my
branch
from
b6dbfb9 to
066b701
Compare
wgtmac
approved these changes
Nov 5, 2025
|
|
||
| Result<ErrorModel> ErrorModelFromJson(const nlohmann::json& json) { | ||
| ErrorModel error; | ||
| // NOTE: Iceberg's Java implementation allows missing required fields (message, type, |
Member
There was a problem hiding this comment.
@Fokko I don't think this is something serious but there is a slight inconsistency between Java impl and the spec.
HeartLinked
force-pushed
the
rest_test_refactor_my
branch
from
066b701 to
1d1602f
Compare
HeartLinked
force-pushed
the
rest_test_refactor_my
branch
from
a0819b3 to
e25ff49
Compare
WillAyd
approved these changes
Nov 5, 2025
HeartLinked
force-pushed
the
rest_test_refactor_my
branch
from
70f37b5 to
9752f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.