feat(cmd/iceberg): add support for writing to branches(snapshot producer)#774
Open
subkanthi wants to merge 8 commits intoapache:mainfrom
Open
feat(cmd/iceberg): add support for writing to branches(snapshot producer)#774subkanthi wants to merge 8 commits intoapache:mainfrom
subkanthi wants to merge 8 commits intoapache:mainfrom
Conversation
…dd_branch_support_snapshot_write # Conflicts: # table/snapshot_producers.go # table/transaction.go # table/transaction_test.go
zeroshade
changed the title
zeroshade
requested changes
Mar 16, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Generally looks good, but I think we can improve the WriteOptions setup you've added. See below
Comment on lines
+868
to
+873
| // WithOverwriteBranch sets the target branch for the overwrite. Default is main. | ||
| func WithOverwriteBranch(branch string) OverwriteOption { | ||
| return func(op *overwriteOperation) { | ||
| op.branch = branch | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
why do we need separate types for OverwriteOption and WriteOption? Can't we reuse the same option type?
| } | ||
|
|
||
| func (t *Transaction) AddFiles(ctx context.Context, files []string, snapshotProps iceberg.Properties, ignoreDuplicates bool) error { | ||
| func (t *Transaction) AddFiles(ctx context.Context, files []string, snapshotProps iceberg.Properties, ignoreDuplicates bool, opts ...WriteOpt) error { |
Member
There was a problem hiding this comment.
should more of these parameters get added as Options instead if we're going to go down this road? We should make all non-required parameters into options then
Comment on lines
+63
to
+73
| func resolveBranch(opts []WriteOpt) string { | ||
| var o writeOpts | ||
| for _, opt := range opts { | ||
| opt.applyWriteOpt(&o) | ||
| } | ||
| if o.branch == "" { | ||
| return MainBranch | ||
| } | ||
|
|
||
| return o.branch | ||
| } |
Member
There was a problem hiding this comment.
instead of resolveBranch, we should have a common config struct and just apply all the options to it and then we grab the values by the properties directly. That would make this more reusable in general
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #714