feat: add construct_ref for table_metadata#1043
Merged
Fokko merged 2 commits intoapache:mainfrom Mar 7, 2025
Merged
Conversation
Contributor
Author
Fokko
previously approved these changes
Mar 7, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
LGTM, should we throw in a test?
Contributor
Author
Have added the test |
Fokko
approved these changes
Mar 7, 2025
Contributor
|
Thanks @ZENOTME 🙌 |
Fokko
added a commit
that referenced
this pull request
Mar 7, 2025
I was checking this while reviewing #1043 I don't think the `current-snapshot-id` can be zero while there are no snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR add a construct_ref to insert the main branch if it's not found in refs. ref from: https://github.com/apache/iceberg-python/blob/f45966208dac7c0a2fbe5b16d643a816db2bacb3/pyiceberg/table/metadata.py#L117
Are these changes tested?