Improve IcebergCommitExec
to correctly populate properties/schema
#1721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR fixes schema mismatch errors (similar to the example shown below) when using
IcebergCommitExec
with DataFusion. This occurs whenIcebergCommitExec
is not the top-level plan but is instead wrapped as the input to another plan node, for example when added by a custom optimization rule (cache invalidation step for example).What changes are included in this PR?
PR updates
compute_properties
logic to use target (output) schema instead of input schema. Below is example DataFusionDataSinkExec
implementation demonstrating that properties must be created based on target schema, not input.https://github.com/apache/datafusion/blob/4eacb6046773b759dae0b3d801fe8cb1c6b65c0f/datafusion/datasource/src/sink.rs#L101C1-L117C6
Are these changes tested?
Tested manually, expanded existing test to verify output schema, tested as part of Spice Iceberg write automated tests