feat(sql-catalog): implement register table for sql catalog #1724
+82
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @CTTY, PTAL when you have some time? Thank you! |
CTTY
reviewed
Oct 10, 2025
There was a problem hiding this comment.
Hi @Standing-Man , thanks for the PR! I've left some comments.
Also, could you add an unit test for this if possible?
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
commented
Oct 10, 2025
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
force-pushed
the
sql-catalog
branch
from
99db14d to
3210334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
register_tablefor sql catalogAre these changes tested?