Scan Delete Support Part 4: Delete File Loading; Skeleton for Processing#982
Conversation
edb1d27 to
8e90bdd
Compare
ec8e7c1 to
06f0df5
Compare
jonathanc-n
left a comment
There was a problem hiding this comment.
This is nice, will look at the parsed records next.
5530bc3 to
e997fc6
Compare
|
@liurenjie1024, @Xuanwo, @Fokko - this is ready for re-review, if you could take a look that would be great! |
e997fc6 to
056e73f
Compare
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @sdd for this pr. There are some missing points in current design. Also I would suggest not putting too much in DeleteFilterManager. I suppose DeleterFilterManager acting more like a delete loader, which manages the io and caching of record batch. The actual filtering part, could delegate to DeleteFilter, WDYT? I think a good reference implementation is java's DeleteFilter, see https://github.com/apache/iceberg/blob/af8e3f5a40f4f36bbe1d868146749e2341471586/data/src/main/java/org/apache/iceberg/data/DeleteFilter.java#L50
|
Thanks for the review @liurenjie1024 - much appreciated. Will come back with a revised design. |
bd33aa5 to
39a26ab
Compare
5739a46 to
52cf8b9
Compare
|
Let's wait for a moment to merge it after 0.5.0 release |
078bba7 to
fc696ef
Compare
20b44ab to
acd7ab8
Compare
|
Hi @liurenjie1024 / @Xuanwo / @xxchan. This is now ready again for review after a refactor taking into account @xxchan's great feedback. I'll be on holiday for a week after today so it would be great if you guys could take a look. Thanks! |
…DeleteVector::intersect_assign pub(crate)
…our of it being always on
acd7ab8 to
b147098
Compare
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @sdd for this pr, I think it's fine to move forward for now.
Extends the
DeleteFileManagerintroduced in #950 To include loading of delete files, storage and retrieval of parsed delete files from shared state, and the outline for how parsing will connect up to this new work.Issue: #630