fix: memory leak during tvlist owner transfer scenario#16932
Merged
JackieTien97 merged 4 commits intoapache:masterfrom Dec 22, 2025
Merged
fix: memory leak during tvlist owner transfer scenario#16932JackieTien97 merged 4 commits intoapache:masterfrom
JackieTien97 merged 4 commits intoapache:masterfrom
Conversation
JackieTien97
requested changes
Dec 19, 2025
...g/apache/iotdb/db/queryengine/plan/planner/memory/NotThreadSafeMemoryReservationManager.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/iotdb/db/queryengine/plan/planner/memory/MemoryReservationManager.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/iotdb/db/queryengine/plan/planner/memory/MemoryReservationManager.java
Outdated
Show resolved
Hide resolved
| * reservedBytesInTotal >= size to ensure proper memory accounting and prevent negative | ||
| * reservation values. | ||
| */ | ||
| Pair<Long, Long> releaseMemoryVirtually(final long size); |
Contributor
There was a problem hiding this comment.
add some java doc about the return value
.../java/org/apache/iotdb/db/queryengine/plan/planner/memory/FakedMemoryReservationManager.java
Outdated
Show resolved
Hide resolved
shizy818
force-pushed
the
fix_tvlist_owner
branch
from
177c45c to
e393847
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Steps to reproduce the issue:
reserveMemoryCumulativelyto reserve memory. Query 1 is added into TVList's query set and be set as owner.releaseMemoryReservationManagerto release memory.releaseMemoryCumulativelyto release memory because Query 2 is the last query and be the owner.Release operation is invoked twice. This PR is to transfer momery virtually from MemoryReservationManager of Query 1 to that of Query 2 without actually allocating/freeing the memory.