Minor: fix AdjustStreamThreadCountTest #20620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
/gemini review |
chia7712
reviewed
Oct 1, 2025
| one.start(); | ||
|
|
||
| assertTrue(latch.await(30, TimeUnit.SECONDS)); | ||
| assertTrue(latch.await(90, TimeUnit.SECONDS)); |
There was a problem hiding this comment.
Why increase the timeout when the number of threads is reduced?
There was a problem hiding this comment.
Hi @chia7712. I think this is not the right way to fix the test, also it's taken by someone else in the community. I guess I'll close this PR. Thanks!
mjsax
reviewed
Oct 2, 2025
| final Thread one = adjustCountHelperThread(kafkaStreams, 4, latch); | ||
| final Thread two = adjustCountHelperThread(kafkaStreams, 6, latch); | ||
| final Thread one = adjustCountHelperThread(kafkaStreams, 1, latch); | ||
| final Thread two = adjustCountHelperThread(kafkaStreams, 1, latch); |
There was a problem hiding this comment.
Not sure if this is the right change? -- The method name literally says MultipleTimes so there seems to be an intent to add/remove threads multiple times. If we reduce this to one, it seems we are removing intended test coverage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdjustStreamThreadCountTest becomes flaky since this upgrade. The root cause is the timeout is not enough, for every remove and create the kafka stream thread, it takes around 10s. Should takes more on CI. I reduce the times of remove & create kafka streams and add longer timeout.