Skip to content

Minor: fix AdjustStreamThreadCountTest #20620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+5 −4
Closed

Minor: fix AdjustStreamThreadCountTest #20620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b87dbe
fix AdjustStreamThreadCountTest
RaidenE1 Oct 1, 2025
371b49f
reduce concurrency
RaidenE1 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public static void closeCluster() {
private static StreamsBuilder builder;
private static Properties properties;
private static String appId = "";
public static final Duration DEFAULT_DURATION = Duration.ofSeconds(30);
public static final Duration DEFAULT_DURATION = Duration.ofSeconds(60);

@BeforeEach
public void setup(final TestInfo testInfo) {
Expand Down Expand Up @@ -272,8 +272,8 @@ public void shouldAddAndRemoveThreadsMultipleTimes() throws InterruptedException
stateTransitionHistory.clear();

final CountDownLatch latch = new CountDownLatch(2);
final Thread one = adjustCountHelperThread(kafkaStreams, 4, latch);
final Thread two = adjustCountHelperThread(kafkaStreams, 6, latch);
final Thread one = adjustCountHelperThread(kafkaStreams, 1, latch);
final Thread two = adjustCountHelperThread(kafkaStreams, 1, latch);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the right change? -- The method name literally says MultipleTimes so there seems to be an intent to add/remove threads multiple times. If we reduce this to one, it seems we are removing intended test coverage?

Set<ThreadMetadata> threadMetadata = null;

AssertionError testError = null;
Expand All @@ -284,13 +284,14 @@ public void shouldAddAndRemoveThreadsMultipleTimes() throws InterruptedException
assertTrue(latch.await(30, TimeUnit.SECONDS));
one.join();
two.join();

waitForCondition(
() -> kafkaStreams.metadataForLocalThreads().size() == oldThreadCount &&
kafkaStreams.state() == KafkaStreams.State.RUNNING,
DEFAULT_DURATION.toMillis(),
"Kafka Streams did not stabilize at the expected thread count and RUNNING state."
);

threadMetadata = kafkaStreams.metadataForLocalThreads();
assertThat(threadMetadata.size(), equalTo(oldThreadCount));
} catch (final AssertionError e) {
Expand Down