KAFKA-17521: Avoid WARN on cleanup when state directory only contains process metadata. #20969
+35
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… process metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KafkaStreams#cleanup(...)currently logs aWARNwhen the state directory cannot be deleted because it is not empty. Since KAFKA-10716, theprocessIdfile is persisted in state directory and is expected to remain across restarts, so this WARN can be misleading when the process metadata file is the only remaining entry.Changes
StateDirectory#clean(...), If the directory contains only theprocess metadatafile, a debug message is logged explaining that the directory was not deleted because it still contains the process metadata file required for stable task assignment across restarts, and no WARN is emitted. If any other file remains, the existing WARN is logged as before.Related Ticket