Skip to content

KAFKA-17521: Avoid WARN on cleanup when state directory only contains process metadata. #20969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+35 −4
Open

KAFKA-17521: Avoid WARN on cleanup when state directory only contains process metadata. #20969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 35 additions & 4 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,10 +556,41 @@ public synchronized void clean() {

try {
if (hasPersistentStores && stateDir.exists() && !stateDir.delete()) {
log.warn(
String.format("%s Failed to delete state store directory of %s for it is not empty",
logPrefix(), stateDir.getAbsolutePath())
);
final File[] remainingFiles = stateDir.listFiles();
if (remainingFiles == null) {
log.warn("{} Failed to delete state store directory of {} for it is not empty",
logPrefix(), stateDir.getAbsolutePath());
return;
}

boolean hasProcessFiles = false;
boolean hasNonProcessFiles = false;

for (final File file : remainingFiles) {
final String name = file.getName();
if (PROCESS_FILE_NAME.equals(name)) {
hasProcessFiles = true;
} else {
hasNonProcessFiles = true;
break;
}
}

if (hasProcessFiles && !hasNonProcessFiles) {
// KAFKA-10716: The processId file is persisted in the state directory to keep the
// processId stable across restarts. Removing it would cause a new processId to be
// generated and may lead to unnecessary task movements during rebalances.
log.debug(
"{} State store directory {} was not deleted because it still contains the " +
"process metadata file {} that is required for stable task assignment across restarts.",
logPrefix(), stateDir.getAbsolutePath(), PROCESS_FILE_NAME
);
} else {
log.warn(
String.format("%s Failed to delete state store directory of %s for it is not empty",
logPrefix(), stateDir.getAbsolutePath())
);
}
}
} catch (final SecurityException exception) {
log.error(
Expand Down