Skip to content

[AUTHZ] make FilteredShowObjectsExec extends V2CommandExec to avoid running executor side task#7202

Closed
LennonChin wants to merge 1 commit intoapache:masterfrom
LennonChin:authz_filtered_show_objects
Closed

[AUTHZ] make FilteredShowObjectsExec extends V2CommandExec to avoid running executor side task#7202
LennonChin wants to merge 1 commit intoapache:masterfrom
LennonChin:authz_filtered_show_objects

Conversation

@LennonChin
Copy link
Contributor

Now FilteredShowObjectsExec is not a subclass of V2CommandExec, when it was executed it will invoke def doExecute(): RDD[InternalRow] method to submit executor side task to run, which is slow and resource wasting. V2CommandExec implemented def executeCollect(): Array[InternalRow] to avoid running def doExecute(): RDD[InternalRow].

Why are the changes needed?

Improve perfomance.

How was this patch tested?

exists unit tests.

Was this patch authored or co-authored using generative AI tooling?

No.

@LennonChin
Copy link
Contributor Author

@bowenliang123 cc

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (8b56295) to head (10b55e6).

Files with missing lines Patch % Lines
...authz/rule/rowfilter/FilteredShowObjectsExec.scala 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7202   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         695     695           
  Lines       43505   43505           
  Branches     5888    5888           
======================================
  Misses      43505   43505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bowenliang123 bowenliang123 added this to the v1.10.3 milestone Sep 19, 2025
bowenliang123 pushed a commit that referenced this pull request Sep 19, 2025
…Exec to avoid running executor side task

Now FilteredShowObjectsExec is not a subclass of V2CommandExec, when it was executed it will invoke `def doExecute(): RDD[InternalRow]` method to submit executor side task to run, which is slow and resource wasting.  V2CommandExec implemented `def executeCollect(): Array[InternalRow]` to avoid running `def doExecute(): RDD[InternalRow]`.

### Why are the changes needed?

Improve perfomance.

### How was this patch tested?

exists unit tests.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #7202 from LennonChin/authz_filtered_show_objects.

Closes #7202

10b55e6 [Lennon Chin] [AUTHZ] make FilteredShowObjectsExec extends V2CommandExec to avoid running executor side task

Authored-by: Lennon Chin <i@coderap.com>
Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
(cherry picked from commit 1bf71a8)
Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants