Skip to content

[AUTHZ] make FilteredShowObjectsExec extends V2CommandExec to avoid running executor side task #7202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LennonChin wants to merge 1 commit into from
Closed

[AUTHZ] make FilteredShowObjectsExec extends V2CommandExec to avoid running executor side task #7202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...n/scala/org/apache/kyuubi/plugin/spark/authz/rule/rowfilter/FilteredShowObjectsExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,31 +18,28 @@ package org.apache.kyuubi.plugin.spark.authz.rule.rowfilter

import org.apache.hadoop.security.UserGroupInformation
import org.apache.spark.SparkContext
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.Attribute
import org.apache.spark.sql.execution.{LeafExecNode, SparkPlan}
import org.apache.spark.sql.execution.datasources.v2.V2CommandExec

import org.apache.kyuubi.plugin.spark.authz.{ObjectType, OperationType}
import org.apache.kyuubi.plugin.spark.authz.ranger.{AccessRequest, AccessResource, AccessType, SparkRangerAdminPlugin}
import org.apache.kyuubi.plugin.spark.authz.util.AuthZUtils

trait FilteredShowObjectsExec extends LeafExecNode {
trait FilteredShowObjectsExec extends V2CommandExec with LeafExecNode {
def result: Array[InternalRow]

override def output: Seq[Attribute]

final override def doExecute(): RDD[InternalRow] = {
sparkContext.parallelize(result, 1)
}
}

trait FilteredShowObjectsCheck {
def isAllowed(r: InternalRow, ugi: UserGroupInformation): Boolean
}

case class FilteredShowNamespaceExec(result: Array[InternalRow], output: Seq[Attribute])
extends FilteredShowObjectsExec {}
extends FilteredShowObjectsExec {
override protected def run(): Seq[InternalRow] = result
}

object FilteredShowNamespaceExec extends FilteredShowObjectsCheck {
def apply(delegated: SparkPlan, sc: SparkContext): FilteredShowNamespaceExec = {
val result = delegated.executeCollect()
Expand All @@ -60,7 +57,10 @@ object FilteredShowNamespaceExec extends FilteredShowObjectsCheck {
}

case class FilteredShowTablesExec(result: Array[InternalRow], output: Seq[Attribute])
extends FilteredShowObjectsExec {}
extends FilteredShowObjectsExec {
override protected def run(): Seq[InternalRow] = result
}

object FilteredShowTablesExec extends FilteredShowObjectsCheck {
def apply(delegated: SparkPlan, sc: SparkContext): FilteredShowNamespaceExec = {
val result = delegated.executeCollect()
Expand Down
Loading