Fix: Ensure jvmrunargs lookup is always registered (fixes #2726) #3874
+140
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
requested changes
Aug 10, 2025
There was a problem hiding this comment.
Hi @ramanathan1504,
Thanks for the PR! 💯
From what I can tell, the jvmrunargs lookup was already fixed in version 2.25.0, so the main code changes here may not be needed. However, the unit tests you’ve added are very valuable. They’ll help ensure the lookup keeps working. The absence of such tests is likely why a feature that never fully worked managed to ship in so many releases.
Could you:
- Remove the main code changes but keep
JvmRunArgsLookupTest. - Consider adding documentation for
jvmrunargs(either in this PR or in a follow-up). See #3876 for details.
log4j-core-test/src/test/java/org/apache/logging/log4j/core/lookup/JvmRunArgsLookupTest.java
Outdated
Show resolved
Hide resolved
Generated by gradle/develocity-actions |
….25.0 - Documented `jvmrunargs` lookup in `lookups.adoc` with usage examples. - Verified that the lookup works correctly in Log4j 2.25.0 using sample app and JVM args. - Included example configuration demonstrating retrieval of JVM runtime arguments. Closes apache#2726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new
jvmrunargslookup in Log4j, allowing users to access JVM runtime arguments via configuration and lookups. The changes include registering the new lookup in theInterpolator, adding tests to verify its registration and behavior, and providing a sample configuration file that demonstrates its usage.New JVM Runtime Arguments Lookup:
jvmrunargslookup in theInterpolatorclass, enabling retrieval of JVM arguments through${jvmrunargs:...}expressions in Log4j configurations.Testing and Verification:
JvmRunArgsLookupTestto verify that thejvmrunargslookup is registered and behaves as expected, including null and non-null cases.JvmRunArgsIntegrationTestto ensure the lookup works correctly within a logging configuration.Configuration Example:
log4j2-test.xmlconfiguration file that demonstrates how to use the newjvmrunargslookup in a pattern layout for console output.