Skip to content

avoid false IO catch on mkdirs() #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pankraz76 wants to merge 1 commit into from
Closed

avoid false IO catch on mkdirs() #2396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo {
private File outputFile;

public void execute() throws MojoExecutionException {
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Failed to create touch file: " + e.getMessage(), e);
Expand Down
2 changes: 1 addition & 1 deletion ...n-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + outputFile);

OutputStream out = null;
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
out = new FileOutputStream(outputFile);
componentProperties.store(out, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
Expand Down
2 changes: 1 addition & 1 deletion ...active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ public void run() {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + outputFile);

OutputStream out = null;
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
out = new FileOutputStream(outputFile);
componentProperties.store(out, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
Expand Down
2 changes: 1 addition & 1 deletion ...n-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ class PropertiesUtil {

public static void write(File outputFile, Properties props) throws MojoExecutionException {
OutputStream out = null;
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
out = new FileOutputStream(outputFile);
props.store(out, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
Expand Down
2 changes: 1 addition & 1 deletion ...-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ public static Properties read(File inputFile) throws MojoExecutionException {

public static void write(File outputFile, Properties props) throws MojoExecutionException {
OutputStream os = null;
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
os = new FileOutputStream(outputFile);
props.store(os, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
Expand Down
3 changes: 1 addition & 2 deletions ...core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,9 @@ public void execute() throws MojoExecutionException, MojoFailureException {
outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
}

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
3 changes: 1 addition & 2 deletions ...stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,9 @@ public void execute() throws MojoExecutionException, MojoFailureException {
outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
}

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
3 changes: 1 addition & 2 deletions ...s/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,9 @@ public void execute() throws MojoExecutionException, MojoFailureException {
outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
}

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...re-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...gin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...n-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/GenerateApplicationXmlMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...gin-core-stubs/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/coreit/EjbMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...-stubs/maven-install-plugin/src/main/java/org/apache/maven/plugin/coreit/InstallMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...gin-core-stubs/maven-jar-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...core-stubs/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...tubs/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/coreit/DescriptorMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...gin-core-stubs/maven-rar-plugin/src/main/java/org/apache/maven/plugin/coreit/RarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...bs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/ResourcesMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();

if (message != null && message.length() > 0) {
getLog().info("[MAVEN-CORE-IT-LOG] " + message);
Expand Down
2 changes: 1 addition & 1 deletion ...aven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/TestResourcesMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion .../maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/AttachDescriptorMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...n-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/SiteMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...-core-stubs/maven-source-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...re-stubs/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/coreit/TestMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion ...gin-core-stubs/maven-war-plugin/src/main/java/org/apache/maven/plugin/coreit/WarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + pathname, e);
Expand Down
2 changes: 1 addition & 1 deletion .../maven-it-plugin-no-default-comp/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ public void execute() throws MojoExecutionException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
try (FileOutputStream os = new FileOutputStream(outputFile)) {
props.store(os, "MAVEN-CORE-IT-LOG");
}
Expand Down
2 changes: 1 addition & 1 deletion ...lugins/maven-it-plugin-online/src/main/java/org/apache/maven/plugin/coreit/TouchMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ public class TouchMojo extends AbstractMojo {
public void execute() throws MojoExecutionException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
outputFile.createNewFile();
} catch (IOException e) {
throw new MojoExecutionException("Output file could not be created: " + outputFile, e);
Expand Down
2 changes: 1 addition & 1 deletion ...ns/maven-it-plugin-packaging/src/main/java/org/apache/maven/plugin/coreit/AppendMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ public class AppendMojo extends AbstractMojo {
public void execute() throws MojoExecutionException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();

getLog().info("[MAVEN-CORE-IT-LOG] " + message);

Expand Down
2 changes: 1 addition & 1 deletion ...en-it-plugin-singleton-component/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ public void execute() throws MojoExecutionException {

getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
try (FileOutputStream os = new FileOutputStream(outputFile)) {
props.store(os, "MAVEN-CORE-IT-LOG");
}
Expand Down
2 changes: 1 addition & 1 deletion ...plugins/maven-it-plugin-site/src/main/java/org/apache/maven/plugin/coreit/InfoReport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);

OutputStream out = null;
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
out = new FileOutputStream(outputFile);
props.store(out, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
Expand Down
2 changes: 1 addition & 1 deletion ...ns/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/CoreItMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ public void execute() throws MojoExecutionException {
}

OutputStream out = null;
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
out = new FileOutputStream(outputFile);
properties.store(out, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
Expand Down
2 changes: 1 addition & 1 deletion .../maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/FindToolMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ public void execute() throws MojoExecutionException {
}

OutputStream out = null;
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
out = new FileOutputStream(outputFile);
properties.store(out, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
Expand Down
2 changes: 1 addition & 1 deletion ...en-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + outputFile);

OutputStream out = null;
outputFile.getParentFile().mkdirs();
try {
outputFile.getParentFile().mkdirs();
out = new FileOutputStream(outputFile);
loaderProperties.store(out, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
Expand Down