MINIFICPP-2682 Move Lua tests to modular docker tests #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaszm
reviewed
Nov 19, 2025
lordgamez
added
depends-on-another-PR
low-impact
lordgamez
force-pushed
the
MINIFICPP-2680
branch
from
2e73b38 to
8dfeed6
Compare
lordgamez
force-pushed
the
MINIFICPP-2682
branch
from
f224cb2 to
0306957
Compare
8 tasks
szaszm
reviewed
Dec 9, 2025
Member
szaszm
left a comment
szaszm
left a comment
There was a problem hiding this comment.
+1 after feedback in earlier dependency PRs are resolved
fgerlits
approved these changes
Dec 16, 2025
fgerlits
requested changes
Dec 17, 2025
Contributor
fgerlits
left a comment
fgerlits
left a comment
There was a problem hiding this comment.
Does this also need to be added to the end of RunBehaveTests.sh?
lordgamez
force-pushed
the
MINIFICPP-2680
branch
from
8dfeed6 to
17d5fe5
Compare
lordgamez
force-pushed
the
MINIFICPP-2682
branch
from
0306957 to
eaa861d
Compare
Contributor
Author
Good catch, fixed in eaa861d |
fgerlits
approved these changes
Jan 7, 2026
szaszm
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2682
Depends on #2074
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.