Use duration converters for close() #2518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Nov 18, 2025
mdedetrich
force-pushed
the
use-duration-converters-for-close
branch
from
da11918 to
653638b
Compare
(cherry picked from commit 29b7d22)
pjfanning
reviewed
Nov 18, 2025
mdedetrich
force-pushed
the
use-duration-converters-for-close
branch
from
653638b to
f6ec89e
Compare
mdedetrich
requested review from
He-Pin,
Roiocam,
danischroeter,
gmethvin,
nvollmar,
pjfanning,
raboof,
samueleresca,
seglo and
softinio
He-Pin
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 29b7d22)