Skip to content

Use duration converters for close() #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdedetrich merged 1 commit into from
Nov 18, 2025
Merged

Use duration converters for close() #2518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions actor/src/main/scala/org/apache/pekko/actor/ActorSystem.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import pekko.japi.Util.immutableSeq
import pekko.serialization.SerializationExtension
import pekko.util._
import pekko.util.FutureConverters._
import pekko.util.JavaDurationConverters._
import pekko.util.OptionConverters._
import pekko.util.Helpers.toRootLowerCase
import pekko.util.ccompat.JavaConverters._
Expand Down Expand Up @@ -1104,10 +1105,8 @@ private[pekko] class ActorSystemImpl(

override def close(): Unit = {
terminate()
val duration =
Duration(settings.config.getDuration("pekko.coordinated-shutdown.close-actor-system-timeout").toMillis,
TimeUnit.MILLISECONDS)
Await.result(whenTerminated, duration)
Await.result(whenTerminated,
settings.config.getDuration("pekko.coordinated-shutdown.close-actor-system-timeout").asScala)
}

override private[pekko] def finalTerminate(): Unit = {
Expand Down
Loading