chore: test Scala 3 with validatePullRequest
#2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Dec 3, 2025
The Scala 3 build+test job takes almost an hour because it runs all tests, while the Scala 2 build+test job is sometimes much faster because it runs with `validatePullRequest` which selects which tests to run based on the files that were changed. I don't think we've regularly seen situations where a failure was missed by `validatePullRequest` and caught by the Scala 3 test, so it might be nice to run those with `validatePullRequest` as well.
raboof
force-pushed
the
test-scala3-with-validatePullRequest
branch
from
32b5242 to
9084bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scala 3 build+test job takes almost an hour because it runs all tests, while the Scala 2 build+test job is sometimes much faster because it runs with
validatePullRequestwhich selects which tests to run based on the files that were changed. I don't think we've regularly seen situations where a failure was missed byvalidatePullRequestand caught by the Scala 3 test, so it might be nice to run those withvalidatePullRequestas well.