chore: remove versions from LICENSE and NOTICE files to "relax" dependecy updates, improving also the wording#3861
chore: remove versions from LICENSE and NOTICE files to "relax" dependecy updates, improving also the wording#3861jbonofre wants to merge 1 commit intoapache:mainfrom
Conversation
…dency updates, improving also the wording
snazy
left a comment
There was a problem hiding this comment.
Removing the versions is fine, and removes a lot of manual work.
I'd prefer to keep the group/artifact mentions in a defined format, because then we can reactivate the currently commented out license-checks here and here.
That check looks for all dependencies and does at least a best-effort dependency check, so we get a build error when new dependencies are added including some hint about the license of those and also an error for incompatible licenses.
| -------------------------------------------------------------------------------- | ||
|
|
||
| This binary artifact bundles the following projects: | ||
| This propduct bundles and includes code from Apache Iceberg. |
There was a problem hiding this comment.
What is the difference between "bundles and includes" vs just "bundles"?
There was a problem hiding this comment.
bundle -> dependencies from a project
includes -> code copied into Polaris
|
This change is included in #3864 |
| Group: com.google.api.grpc Name: grpc-google-cloud-storage-v2 Version: 2.60.0 | ||
| Group: com.google.api.grpc Name: proto-google-cloud-monitoring-v3 Version: 3.52.0 | ||
| Group: com.google.api.grpc Name: proto-google-cloud-storage-v2 Version: 2.60.0 | ||
| This product bundles Storage APIs. |
There was a problem hiding this comment.
| This product bundles Storage APIs. | |
| This product bundles Google gRPC Storage APIs. |
|
Closing as the change has been merged as part of #3881 |
This closes #2484