Skip to content

chore: remove versions from LICENSE and NOTICE files to "relax" dependecy updates, improving also the wording#3861

Closed
jbonofre wants to merge 1 commit intoapache:mainfrom
jbonofre:gh-2484
Closed

chore: remove versions from LICENSE and NOTICE files to "relax" dependecy updates, improving also the wording#3861
jbonofre wants to merge 1 commit intoapache:mainfrom
jbonofre:gh-2484

Conversation

@jbonofre
Copy link
Member

This closes #2484

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Feb 23, 2026
@jbonofre jbonofre added this to the 1.4.0 milestone Feb 23, 2026
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the versions is fine, and removes a lot of manual work.

I'd prefer to keep the group/artifact mentions in a defined format, because then we can reactivate the currently commented out license-checks here and here.

That check looks for all dependencies and does at least a best-effort dependency check, so we get a build error when new dependencies are added including some hint about the license of those and also an error for incompatible licenses.

--------------------------------------------------------------------------------

This binary artifact bundles the following projects:
This propduct bundles and includes code from Apache Iceberg.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between "bundles and includes" vs just "bundles"?

Copy link
Member

@snazy snazy Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle -> dependencies from a project
includes -> code copied into Polaris

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct 😀

@snazy
Copy link
Member

snazy commented Feb 23, 2026

This change is included in #3864

Group: com.google.api.grpc Name: grpc-google-cloud-storage-v2 Version: 2.60.0
Group: com.google.api.grpc Name: proto-google-cloud-monitoring-v3 Version: 3.52.0
Group: com.google.api.grpc Name: proto-google-cloud-storage-v2 Version: 2.60.0
This product bundles Storage APIs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This product bundles Storage APIs.
This product bundles Google gRPC Storage APIs.

@snazy
Copy link
Member

snazy commented Mar 3, 2026

Closing as the change has been merged as part of #3881

@snazy snazy closed this Mar 3, 2026
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify distribution LICENSE/NOTICE

4 participants