-
Notifications
You must be signed in to change notification settings - Fork 368
[Issue 443] add context param in producer interceptor #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cckellogg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking api change so we may need to figure out if that is ok or figure out if backwards compatibility is needed.
|
The Logic LGTM +1, as @cckellogg said, maybe we can add a new API for this change, e.g: |
Adding a new function to the interface will still be a breaking change. Applications will have have to implement the new method and recompile. I think that's what we need to figure out. Do we need to support backward compatibility or is making a breaking api change ok for the next release. |
Yes, my mistake. It seems that adding context does have actual usage scenarios and can further improve the processing capabilities of the interceptor itself. If we want to add this feature without breaking backward compatibility, can we try to directly expose a new interface to the user in ProducerOptions? For exampels, in and introduce a new interface But it is not a very elegant way to achieve |
liangyuanpeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO,I agree with making a breaking api change ok for the next release..
This PR address issue-443
Ability to add properties to message before sending using context param.
Modified the producer interceptor methods to accept
contextparameter.