Skip to content

[Issue 443] add context param in producer interceptor #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GPrabhudas wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[Issue 443] add context param in producer interceptor #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a865358
add context param in producer interceptor
Sep 8, 2021
1bdccde
remove context from anAck method
Sep 8, 2021
8b25fb8
add comment
Sep 8, 2021
0f555f7
dummy commit to trigger CI
Oct 1, 2021
7603a95
Merge branch 'master' of https://github.com/apache/pulsar-client-go i…
Oct 1, 2021
1fbe3d1
dummy commit
Oct 6, 2021
4b6c7e9
revert of dummy commit
Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pulsar/producer_interceptor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@

package pulsar

import "context"

type ProducerInterceptor interface {
// BeforeSend This is called before send the message to the brokers. This method is allowed to modify the
BeforeSend(producer Producer, message *ProducerMessage)
BeforeSend(ctx context.Context, producer Producer, message *ProducerMessage)

// OnSendAcknowledgement This method is called when the message sent to the broker has been acknowledged,
// or when sending the message fails.
Expand All @@ -28,9 +30,9 @@ type ProducerInterceptor interface {

type ProducerInterceptors []ProducerInterceptor

func (x ProducerInterceptors) BeforeSend(producer Producer, message *ProducerMessage) {
func (x ProducerInterceptors) BeforeSend(ctx context.Context, producer Producer, message *ProducerMessage) {
for i := range x {
x[i].BeforeSend(producer, message)
x[i].BeforeSend(ctx, producer, message)
}
}

Expand Down
3 changes: 2 additions & 1 deletion pulsar/producer_partition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,8 @@ func (p *partitionProducer) internalSendAsync(ctx context.Context, msg *Producer
flushImmediately: flushImmediately,
publishTime: time.Now(),
}
p.options.Interceptors.BeforeSend(p, msg)
// call interceptor with context parameter
p.options.Interceptors.BeforeSend(ctx, p, msg)

if p.options.DisableBlockIfQueueFull {
if !p.publishSemaphore.TryAcquire() {
Expand Down
5 changes: 3 additions & 2 deletions pulsar/producer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,8 @@ func TestProducuerSendFailOnInvalidKey(t *testing.T) {

type noopProduceInterceptor struct{}

func (noopProduceInterceptor) BeforeSend(producer Producer, message *ProducerMessage) {}
func (noopProduceInterceptor) BeforeSend(ctx context.Context, producer Producer, message *ProducerMessage) {
}

func (noopProduceInterceptor) OnSendAcknowledgement(producer Producer, message *ProducerMessage, msgID MessageID) {
}
Expand All @@ -1118,7 +1119,7 @@ type metricProduceInterceptor struct {
ackn int
}

func (x *metricProduceInterceptor) BeforeSend(producer Producer, message *ProducerMessage) {
func (x *metricProduceInterceptor) BeforeSend(ctx context.Context, producer Producer, message *ProducerMessage) {
x.sendn++
}

Expand Down