[SPARK-53404] Make Build step to verify test compilation too
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
BUILD_TEST_CODE
branch
from
ec0fd2f to
8959689
Compare
dongjoon-hyun
changed the title
Build step to verify test compilation too
|
Merged to main to save the CI resources. |
|
Thank you, @viirya . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to make
Buildstep to verify test compilation too.Why are the changes needed?
Like Apache Spark main repo, SPARK-53376 added the
Buildstep before running the actual test.buildfirst before runningtest#222However, it turns out that the test code building is not verified correctly. So, this PR aims to use the following workaround to verify test code fully without running any test.
In addition, this reduces the total runtime of CIs like the following example.
Does this PR introduce any user-facing change?
No. This is a test infra change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.