Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 27, 2025

What changes were proposed in this pull request?

This PR aims to clean up build warnings.

Why are the changes needed?

BEFORE

$ swift build | grep warning
/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/ArrowReader.swift:301:27: warning: 'as' test is always true
    |                           `- warning: 'as' test is always true
/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/ArrowReader.swift:364:25: warning: 'as' test is always true
    |                         `- warning: 'as' test is always true
/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/ArrowReader.swift:301:27: warning: 'as' test is always true
    |                           `- warning: 'as' test is always true
/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/ArrowReader.swift:364:25: warning: 'as' test is always true
    |                         `- warning: 'as' test is always true
/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/ArrowReader.swift:301:27: warning: 'as' test is always true
    |                           `- warning: 'as' test is always true
/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/ArrowReader.swift:364:25: warning: 'as' test is always true
    |                         `- warning: 'as' test is always true

AFTER

$ swift build | grep warning

Does this PR introduce any user-facing change?

A code cleanup.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Mar 27, 2025

Could you review this minor Swift build warning fix when you have some time, @MaxGekk ?

@dongjoon-hyun
Copy link
Member Author

Thank you, @MaxGekk and @viirya .

@dongjoon-hyun
Copy link
Member Author

Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the minor branch March 27, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants