Skip to content

[MINOR] Fix build warnings #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[MINOR] Fix build warnings #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Sources/SparkConnect/ArrowReader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,8 @@ public class ArrowReader { // swiftlint:disable:this type_body_length
messageEndOffset: messageEndOffset
).get()
result.batches.append(recordBatch)
} catch let error as ArrowError {
} catch let error {
return .failure(error)
} catch {
return .failure(.unknownError("Unexpected error: \(error)"))
}
default:
return .failure(.unknownError("Unhandled header type: \(message.headerType)"))
Expand Down Expand Up @@ -361,10 +359,8 @@ public class ArrowReader { // swiftlint:disable:this type_body_length
).get()
result.batches.append(recordBatch)
return .success(())
} catch let error as ArrowError {
} catch let error {
return .failure(error)
} catch {
return .failure(.unknownError("Unexpected error: \(error)"))
}

default:
Expand Down
2 changes: 1 addition & 1 deletion Tests/SparkConnectTests/RuntimeConfTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ struct RuntimeConfTests {
_ = try await client.connect(UUID().uuidString)
let conf = RuntimeConf(client)

#expect(try await conf.get("spark.app.name") != nil)
#expect(try await !conf.get("spark.app.name").isEmpty)

try await #require(throws: Error.self) {
try await conf.get("spark.test.non-exist")
Expand Down
Loading