[SPARK-51953] Support Java 24 #178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
previously approved these changes
Apr 29, 2025
dongjoon-hyun
force-pushed
the
SPARK-51953
branch
4 times, most recently
from
910127d to
c006e07
Compare
dongjoon-hyun
force-pushed
the
SPARK-51953
branch
from
c006e07 to
123c058
Compare
Member
Author
|
It's ready. Could you review this once more, @viirya ? |
Member
Author
|
Also, cc @jiangzho |
viirya
reviewed
Apr 30, 2025
| consoleOutput = true | ||
| ignoreFailures = false | ||
| } | ||
| if (JavaVersion.current() < JavaVersion.VERSION_24) { |
Member
There was a problem hiding this comment.
We cannot have these plugins for Java 24?
Member
Author
There was a problem hiding this comment.
Yes, these two plugins doesn't support Java 24 yet.
The development speed is not the same~
Member
Author
There was a problem hiding this comment.
BTW, these tools (PMD and spotbugs) are static code analysis tools. So, Java 17/21 test coverage are enough already. We don't need them in Java 24.
viirya
approved these changes
Apr 30, 2025
Member
Author
|
Thank you, @viirya ! Merged to main. |
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 30, 2025
### What changes were proposed in this pull request? This PR aims to update `Compatibility` section of `docs/operations.md`. ### Why are the changes needed? To make it up-to-date with newer Java and K8s versions. - apache/spark#49684 - #178 ### Does this PR introduce _any_ user-facing change? No, this is a doc-only change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #179 from dongjoon-hyun/SPARK-51965. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support Java 24 as a preparation of Java 25 LTS.
lombok,jacoco, andmockitolibraries to support Java 24.pmdandspotbugsplugins.--enable-native-access=ALL-UNNAMEDtoDEFAULT_JVM_OPTS.SPARK_USER=sparkenvironment to the operator pod explicitly.4.0.0-preview2dependency to4.0.1-SNAPSHOTto validate with the upcomingApache Spark 4.0.0 RC5.azul/zulu-openjdk:24-jreas the docker base image.Java 24to the CI.Why are the changes needed?
To support Java 24 as a preparation of Java 25 LTS.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.