Skip to content

[SPARK-51953] Support Java 24 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-51953] Support Java 24 #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
fail-fast: false
matrix:
os: [ 'ubuntu-latest', 'ubuntu-24.04-arm' ]
java-version: [ 17, 21 ]
java-version: [ 17, 21, 24 ]
steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion build-tools/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ COPY . .

RUN --mount=type=cache,target=/home/gradle/.gradle/caches gradle --no-daemon clean build -x check

FROM azul/zulu-openjdk:21-jre
FROM azul/zulu-openjdk:24-jre

ARG APP_VERSION=0.1.0-SNAPSHOT
ARG SPARK_UID=185
Expand Down
2 changes: 2 additions & 0 deletions build-tools/helm/spark-kubernetes-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ operatorDeployment:
operatorContainer:
jvmArgs: "-Dfile.encoding=UTF8"
env:
- name: "SPARK_USER"
value: "spark"
envFrom:
volumeMounts: { }
resources:
Expand Down
33 changes: 19 additions & 14 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ subprojects {

repositories {
mavenCentral()
maven {
url = "https://repository.apache.org/content/repositories/snapshots/"
}
}

apply plugin: 'checkstyle'
Expand All @@ -68,22 +71,24 @@ subprojects {
showViolations = true
}

apply plugin: 'pmd'
pmd {
ruleSetFiles = files("$rootDir/config/pmd/ruleset.xml")
toolVersion = libs.versions.pmd.get()
consoleOutput = true
ignoreFailures = false
}
if (JavaVersion.current() < JavaVersion.VERSION_24) {
Copy link
Member

@viirya viirya Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot have these plugins for Java 24?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these two plugins doesn't support Java 24 yet.

The development speed is not the same~

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, these tools (PMD and spotbugs) are static code analysis tools. So, Java 17/21 test coverage are enough already. We don't need them in Java 24.

apply plugin: 'pmd'
pmd {
ruleSetFiles = files("$rootDir/config/pmd/ruleset.xml")
toolVersion = libs.versions.pmd.get()
consoleOutput = true
ignoreFailures = false
}

apply plugin: 'com.github.spotbugs'
spotbugs {
toolVersion = libs.versions.spotbugs.tool.get()
afterEvaluate {
reportsDir = file("${project.reporting.baseDir}/findbugs")
apply plugin: 'com.github.spotbugs'
spotbugs {
toolVersion = libs.versions.spotbugs.tool.get()
afterEvaluate {
reportsDir = file("${project.reporting.baseDir}/findbugs")
}
excludeFilter = file("$rootDir/config/spotbugs/spotbugs_exclude.xml")
ignoreFailures = false
}
excludeFilter = file("$rootDir/config/spotbugs/spotbugs_exclude.xml")
ignoreFailures = false
}

apply plugin: 'jacoco'
Expand Down
8 changes: 4 additions & 4 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@
# under the License.
[versions]
fabric8 = "7.1.0"
lombok = "1.18.32"
lombok = "1.18.38"
operator-sdk = "4.9.0"
okhttp = "4.12.0"
dropwizard-metrics = "4.2.25"
spark = "4.0.0-preview2"
spark = "4.0.1-SNAPSHOT"
log4j = "2.24.2"

# Test
junit = "5.10.2"
jacoco = "0.8.12"
mockito = "5.11.0"
jacoco = "0.8.13"
mockito = "5.17.0"
powermock = "2.0.9"

# Build Analysis
Expand Down
2 changes: 1 addition & 1 deletion gradlew
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ fi


# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m" "--enable-native-access=ALL-UNNAMED"'

# Collect all arguments for the java command:
# * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,
Expand Down
Loading