[SPARK-52657] Allow spark.app.id
#271
Closed
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TQJADE
changed the title
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you fill the PR description, @TQJADE ?
| return SparkAppDriverConf.create( | ||
| effectiveSparkConf, | ||
| appId, | ||
| effectiveSparkConf.getAppId(), |
Member
There was a problem hiding this comment.
Please add a test case to SparkAppSubmissionWorkerTest.java.
dongjoon-hyun
changed the title
spark.app.id
dongjoon-hyun
changed the title
spark.app.idspark.app.id
dongjoon-hyun
approved these changes
Jul 2, 2025
viirya
approved these changes
Jul 3, 2025
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SparkAppDriverConf should use the value stored in effectiveSparkConf rather than pre-computed Id for creation.
Why are the changes needed?
When user set the spark.app.id in sparkConf, operator should honor this value.
Does this PR introduce any user-facing change?
no
How was this patch tested?
unit test
Was this patch authored or co-authored using generative AI tooling?
no