Skip to content

[SPARK-52657] Allow spark.app.id #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TQJADE wants to merge 2 commits into from
Closed

[SPARK-52657] Allow spark.app.id #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3741f96
Fix the bug when user has set the spark.app.id value
TQJADE Jul 2, 2025
394bdb9
Add unit test
TQJADE Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...bmission-worker/src/main/java/org/apache/spark/k8s/operator/SparkAppSubmissionWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ protected SparkAppDriverConf buildDriverConf(
effectiveSparkConf.setIfMissing("spark.app.id", appId);
return SparkAppDriverConf.create(
effectiveSparkConf,
appId,
effectiveSparkConf.getAppId(),
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case to SparkAppSubmissionWorkerTest.java.

Copy link
Contributor Author

@TQJADE TQJADE Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @TQJADE .

primaryResource,
applicationSpec.getMainClass(),
applicationSpec.getDriverArgs().toArray(String[]::new),
Expand Down
16 changes: 16 additions & 0 deletions ...sion-worker/src/test/java/org/apache/spark/k8s/operator/SparkAppSubmissionWorkerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,4 +219,20 @@ void generatedSparkAppIdShouldComplyLengthLimit() {
String appId = SparkAppSubmissionWorker.generateSparkAppId(mockApp);
assertTrue(appId.length() <= DEFAULT_ID_LENGTH_LIMIT);
}

@Test
void checkAppIdWhenUserSpecifiedInSparkConf() {
SparkApplication mockApp = mock(SparkApplication.class);
ApplicationSpec mockSpec = mock(ApplicationSpec.class);
Map<String, String> appProps = new HashMap<>();
appProps.put("spark.app.id", "foo");
ObjectMeta appMeta = new ObjectMetaBuilder().withName("app1").withNamespace("ns1").build();
when(mockSpec.getSparkConf()).thenReturn(appProps);
when(mockApp.getSpec()).thenReturn(mockSpec);
when(mockApp.getMetadata()).thenReturn(appMeta);

SparkAppSubmissionWorker submissionWorker = new SparkAppSubmissionWorker();
SparkAppDriverConf conf = submissionWorker.buildDriverConf(mockApp, Collections.emptyMap());
assertEquals(conf.appId(), "foo");
}
}
Loading