[SPARK-52702] Verify generated CRD yaml with Helm chart crds content
#283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in Helm charts ### What changes were proposed in this pull request? This PR adds a gradle task to compare latest CRD version vs the one used by Helm charts ### Why are the changes needed? To avoid potential human error when updating spark-operator-api ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CIs ### Was this patch authored or co-authored using generative AI tooling? No
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @jiangzho . Yes, we need this kind of assertion.
dongjoon-hyun
changed the title
crds content
Member
|
cc @peter-toth |
dongjoon-hyun
approved these changes
Jul 11, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to main.
Contributor
|
Late LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a gradle task to compare latest CRD version vs the one used by Helm charts
Why are the changes needed?
To avoid potential human error when updating spark-operator-api
Does this PR introduce any user-facing change?
No
How was this patch tested?
CIs
Was this patch authored or co-authored using generative AI tooling?
No