Skip to content

[SPARK-52702] Verify generated CRD yaml with Helm chart crds content #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiangzho wants to merge 1 commit into from
Closed

[SPARK-52702] Verify generated CRD yaml with Helm chart crds content #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions spark-operator-api/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,43 @@ tasks.register('relocateGeneratedCRD', Copy) {
into "../build-tools/helm/spark-kubernetes-operator/crds"
rename '(.+).yml', '$1.yaml'
}

tasks.register("assertGeneratedCRDMatchesHelmChart") {
dependsOn 'finalizeGeneratedCRD'
description = 'Asserts that the generated CRD yaml matches the staged version in Helm Chart'
doLast {
def currentPath = projectDir.absolutePath
def generatedCRDFileBase = "$currentPath/build/classes/java/main/META-INF/fabric8/"
def stagedCRDFileBase = "$currentPath/../build-tools/helm/spark-kubernetes-operator/crds/"
def generatedAppCRD = [
"yq",
"e",
".spec.versions[0]",
"${generatedCRDFileBase}sparkapplications.spark.apache.org-v1.yml"
].execute().text.trim()
def generatedClusterCRD = [
"yq",
"e",
".spec.versions[0]",
"${generatedCRDFileBase}sparkclusters.spark.apache.org-v1.yml"
].execute().text.trim()
def stagedAppCRD = [
"yq",
"e",
".spec.versions[-1]",
"${stagedCRDFileBase}sparkapplications.spark.apache.org-v1.yaml"
].execute().text.trim()
def stagedClusterCRD = [
"yq",
"e",
".spec.versions[-1]",
"${stagedCRDFileBase}sparkclusters.spark.apache.org-v1.yaml"
].execute().text.trim()
if (generatedAppCRD != stagedAppCRD || generatedClusterCRD != stagedClusterCRD) {
throw new GradleException("Generated CRD yaml does not match the staged version in " +
"Helm Chart, please keep the chart updated.")
}
}
}

test.finalizedBy('assertGeneratedCRDMatchesHelmChart')
Loading