Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Oct 2, 2025

What changes were proposed in this pull request?

This PR aims to exclude Spark's transitive dependencies consistently across modules.

Why are the changes needed?

Currently spark-operator and spark-submission-worker modules have heterogeneous exclusion rules against Apache Spark. To be complete, we need to be consistent.

compileOnly(libs.spark.core) {
exclude group: "com.github.luben"
exclude group: "io.netty", module: "netty-tcnative-boringssl-static"
exclude group: "io.netty", module: "netty-tcnative-classes"
exclude group: "org.apache.logging.log4j"
exclude group: "org.fusesource.leveldbjni"
exclude group: "org.lz4"
exclude group: "org.rocksdb"
exclude group: "org.slf4j"
exclude group: "org.xerial.snappy"
}

implementation(libs.spark.kubernetes) {
exclude group: "io.fabric8"
exclude group: "com.github.luben"
exclude group: "io.netty", module: "netty-tcnative-boringssl-static"
exclude group: "io.netty", module: "netty-tcnative-classes"
exclude group: "org.fusesource.leveldbjni"
exclude group: "org.lz4"
exclude group: "org.rocksdb"
exclude group: "org.xerial.snappy"
exclude group: 'commons-collections', module: 'commons-collections'
}

This PR proposes the following sorted list which is a union of the existing exclusions for both modules.

    exclude group: "com.github.luben"
    exclude group: "commons-collections", module: "commons-collections'
    exclude group: "io.fabric8"
    exclude group: "io.netty", module: "netty-tcnative-boringssl-static"
    exclude group: "io.netty", module: "netty-tcnative-classes"
    exclude group: "org.apache.logging.log4j"
    exclude group: "org.fusesource.leveldbjni"
    exclude group: "org.lz4"
    exclude group: "org.rocksdb"
    exclude group: "org.slf4j"
    exclude group: "org.xerial.snappy"

Does this PR introduce any user-facing change?

No behavior change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun force-pushed the SPARK-53781 branch 3 times, most recently from 86cf400 to 0bf517b Compare October 2, 2025 02:57
@dongjoon-hyun dongjoon-hyun marked this pull request as draft October 2, 2025 03:08
@dongjoon-hyun
Copy link
Member Author

It seems that we need to make SLF4J dependency straight first.

@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review October 2, 2025 04:50
@dongjoon-hyun
Copy link
Member Author

After log issues were fixed and merged, this PR passes the CIs.

implementation(libs.metrics.jvm)
compileOnly(libs.spark.core) {
exclude group: "com.github.luben"
exclude group: "commons-collections", module: "commons-collections"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missed in spark-operator module.

implementation(libs.log4j.slf4j2.impl)
implementation(libs.slf4j.api)

implementation(libs.spark.kubernetes) {
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exclusion list is adjusted and sorted.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @peter-toth ?

@dongjoon-hyun
Copy link
Member Author

Thank you, @peter-toth . Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-53781 branch October 2, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants