-
Notifications
You must be signed in to change notification settings - Fork 47
[SPARK-53781] Exclude Spark's transitive dependencies consistently across modules #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
86cf400 to
0bf517b
Compare
|
It seems that we need to make SLF4J dependency straight first. |
170dbea to
1b13f01
Compare
1b13f01 to
74acc3c
Compare
|
After log issues were fixed and merged, this PR passes the CIs. |
| implementation(libs.metrics.jvm) | ||
| compileOnly(libs.spark.core) { | ||
| exclude group: "com.github.luben" | ||
| exclude group: "commons-collections", module: "commons-collections" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missed in spark-operator module.
| implementation(libs.log4j.slf4j2.impl) | ||
| implementation(libs.slf4j.api) | ||
|
|
||
| implementation(libs.spark.kubernetes) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exclusion list is adjusted and sorted.
|
Could you review this PR, @peter-toth ? |
|
Thank you, @peter-toth . Merged to main. |
What changes were proposed in this pull request?
This PR aims to exclude
Spark's transitive dependencies consistently across modules.Why are the changes needed?
Currently
spark-operatorandspark-submission-workermodules have heterogeneous exclusion rules against Apache Spark. To be complete, we need to be consistent.spark-kubernetes-operator/spark-operator/build.gradle
Lines 41 to 51 in 2366928
spark-kubernetes-operator/spark-submission-worker/build.gradle
Lines 23 to 33 in 2366928
This PR proposes the following sorted list which is a union of the existing exclusions for both modules.
Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.