Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Oct 7, 2025

What changes were proposed in this pull request?

This PR aims to

  • Use org.apache.spark.util.Pair class instead of org.apache.commons.lang3.tuple.Pair
  • Add a Checkstyle rule to ban org.apache.commons.lang3.tuple package

Why are the changes needed?

To be consistent with the Apache Spark main repository.

Since Java 16, we can use Records officially in Java and Spark supports Pair via Java Record.

VERSION JEP
Java 14 JEP 359: Records (Preview)
Java 15 JEP 384: Records (Second Preview)
Java 16 JEP 395: Records

Does this PR introduce any user-facing change?

No behavior change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya !

@dongjoon-hyun
Copy link
Member Author

Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-53817 branch October 7, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants