Skip to content

[SPARK-53817] Use o.a.s.util.Pair instead of o.a.commons.lang3.tuple.Pair #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-53817] Use o.a.s.util.Pair instead of o.a.commons.lang3.tuple.Pair #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/checkstyle/checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@
<property name="illegalPkgs" value="org.apache.log4j"/>
<property name="illegalPkgs" value="org.apache.commons.lang"/>
<property name="illegalPkgs" value="org.apache.commons.collections"/>
<property name="illegalPkgs" value="org.apache.commons.lang3.tuple" />
</module>
</module>
</module>
6 changes: 3 additions & 3 deletions .../main/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
import com.codahale.metrics.MetricRegistry;
import io.fabric8.kubernetes.client.http.*;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.tuple.Pair;

import org.apache.spark.metrics.source.Source;
import org.apache.spark.util.Pair;

/** Interceptor for Kubernetes client to collect metrics. */
@Slf4j
Expand Down Expand Up @@ -174,9 +174,9 @@ private void updateRequestMetrics(HttpRequest request) {
parseNamespaceScopedResource(request.uri().getPath());
resourceNamePairOptional.ifPresent(
pair -> {
getMeterByRequestMethodAndResourceName(pair.getValue(), request.method()).mark();
getMeterByRequestMethodAndResourceName(pair.getRight(), request.method()).mark();
getMeterByRequestMethodAndResourceName(
pair.getKey() + "." + pair.getValue(), request.method())
pair.getLeft() + "." + pair.getRight(), request.method())
.mark();
});
}
Expand Down
Loading