[SPARK-53871] Upgrade JUnit to 6.0.0
#383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Thank you, @viirya . |
Member
Author
|
Merged to main. |
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 10, 2025
### What changes were proposed in this pull request? This PR aims to revisit `JUnit` assertion usage in test cases after upgrading to `JUnit 6`. - #383 ### Why are the changes needed? There are three cases: 1. Fix wrong usage of `assertEquals`: The first parameter is the expected value. ```java - assertEquals(previousGeneration2, 1L); + assertEquals(1L, previousGeneration2); ``` 2. `assertNull` is better than `assertEquals(null, *)`. ```java - assertEquals(null, spec1.runtimeVersions.jdkVersion); - assertEquals(null, spec1.runtimeVersions.scalaVersion); - assertEquals(null, spec1.runtimeVersions.sparkVersion); + assertNull(spec1.runtimeVersions.jdkVersion); + assertNull(spec1.runtimeVersions.scalaVersion); + assertNull(spec1.runtimeVersions.sparkVersion); ``` 3. `assertInstanceOf` is more intuitive than `assertTrue(... instanceof ...)`. ```java - assertTrue(constructorArgs.get(conf).get(0) instanceof SparkConf); + assertInstanceOf(SparkConf.class, constructorArgs.get(conf).get(0)); ``` ### Does this PR introduce _any_ user-facing change? No. This is a test case fix and improvement. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #384 from dongjoon-hyun/SPARK-53872. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
JUnitto 6.0.0.Why are the changes needed?
JUnit 6 is released finally.
Does this PR introduce any user-facing change?
No behavior change because this is a test dependency.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.