Skip to content

Conversation

Ma77Ball
Copy link
Contributor

@Ma77Ball Ma77Ball commented Jul 30, 2025

Purpose

This pull request moves the delete button on links from the sending operator to the receiving operator to avoid overlap.

Closes #3074

Summary of Changes

  • Changed link delete button from tool markup to a linktools.button
  • changed the distance of the info button to -60 to start from the end of the link
  • Subscribe to linkView and add info and remove button using the tools view

Demo

Screenshot from 2025-07-30 14-51-50

@Ma77Ball Ma77Ball marked this pull request as draft July 30, 2025 23:10
@Ma77Ball Ma77Ball marked this pull request as ready for review July 30, 2025 23:11
@aglinxinyuan aglinxinyuan self-requested a review September 3, 2025 21:18
@aglinxinyuan aglinxinyuan added the gui Changes related to the frontend GUI label Sep 3, 2025
@aglinxinyuan aglinxinyuan requested a review from Copilot September 4, 2025 02:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes an issue where link delete buttons were overlapping by relocating them from the sending operator to the receiving operator side of the link.

  • Changed the delete button from tool markup to a proper linktools.button implementation
  • Modified the info button position to start from the end of the link (distance: -60)
  • Updated the link mouse enter event handler to use tools view for better button management

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
joint-ui.service.ts Added new getRemoveButton() method and updated info button positioning
workflow-editor.component.ts Refactored link mouse enter handler to use tools view instead of direct attribute manipulation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments provided by Copilot and provide a new demo that addresses the following issues:

  1. The resolution of the screenshot is too low.
  2. The demo does not clearly show how this PR resolves the issue of multiple links having overlapping delete buttons.

@chenlica chenlica self-requested a review September 4, 2025 21:46
@chenlica
Copy link
Contributor

chenlica commented Sep 4, 2025

I added myself as a reviewer. Please do not merge it without my approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Changes related to the frontend GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete button is hard to use
3 participants