-
Notifications
You must be signed in to change notification settings - Fork 96
fix(ui): Prevent link delete buttons from overlapping #3602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(ui): Prevent link delete buttons from overlapping #3602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes an issue where link delete buttons were overlapping by relocating them from the sending operator to the receiving operator side of the link.
- Changed the delete button from tool markup to a proper linktools.button implementation
- Modified the info button position to start from the end of the link (distance: -60)
- Updated the link mouse enter event handler to use tools view for better button management
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
joint-ui.service.ts | Added new getRemoveButton() method and updated info button positioning |
workflow-editor.component.ts | Refactored link mouse enter handler to use tools view instead of direct attribute manipulation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/gui/src/app/workspace/service/joint-ui/joint-ui.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments provided by Copilot and provide a new demo that addresses the following issues:
- The resolution of the screenshot is too low.
- The demo does not clearly show how this PR resolves the issue of multiple links having overlapping delete buttons.
I added myself as a reviewer. Please do not merge it without my approval. |
Purpose
This pull request moves the delete button on links from the sending operator to the receiving operator to avoid overlap.
Closes #3074
Summary of Changes
Demo