Go GLV replace Bytecode with GremlinLang & update serialization to GraphBinary 4 #3292

xiazcy · 2026-01-05T17:43:09Z

A follow up of #3059 to make the go GLV working and buildable in master. Most implementations were done previously inside a feature branch, updates were needed due to accumulated tech debts in the past year.

Major changes included in this PR:

GremlinLang replace Bytecode
GraphBinary 4

Additional changes includes test set-up fixes, HTTP connection updates, basic auth, and various update in traversal to enable successful build.

Major changes pending:

Response chunk streaming (entire response is processed at once)
Interceptors (ie. authentication)

…dates will be needed when connection is set up. * update graph binary serializer to 4.0.0 spec * Updated datetime, added GValue, updated Options strategy, removed unneeded strategy package name, added NewTraversalStrategy to allow custom strategies. (#3056) * Replace websockets with http. Changed connection pooling to be delegated to aio http library. Added POC changes to request serialization just to make happy path work. Full connection configuration and response chunking not yet implemented. (#3057) * update gremlinlang to use slices to store instructions instead * update strategies test after gremlinlang change * update serializer to use marker * fix strategies translation and add missing strategies * Remove result set map container as it is no longer needed. * Removed concept of session as it is no longer needed. * Read response status code from graph binary response. * Removed response status attributes as they no longer exist. * Read response status message and exception strings. * Remove gremlin-socket-server from docker compose. * Removed socket server tests. * Changed transporter to delegate most of the request creation to client library by using http.NewRequest. Removed requestId as it's no longer used. Made some small logging changes. * Removed unused request op attribute. * Removed unused request processor. * Added some comments, refactored error handling and resource closing. * Removed reference to partial content status code. Added some comments and did some minor cleanup. * Removed reference to response metadata. * Removed unused synchronized mpa. * Removed tests for custom type serialization. Removed response id as it is no longer used. Adjusted expected serialized request bytes according to TP4 format. Adjusted bytes for testing deserialization according to TP4 format. Removed serializer unwrapping of single item results as it was causing serialization test to fail. (#3066) fix various gremlinlang and serializer bugs in go for http

vkagamlyk · 2026-01-05T20:11:48Z

gremlin-go/examples/go.sum

 github.com/gorilla/websocket v1.5.3/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=
 github.com/nicksnyder/go-i18n/v2 v2.5.0 h1:3wH1gpaekcgGuwzWdSu7JwJhH9Tk87k1ezt0i1p2/Is=
 github.com/nicksnyder/go-i18n/v2 v2.5.0/go.mod h1:DrhgsSDZxoAfvVrBVLXoxZn/pN5TXqaDbq7ju94viiQ=
+github.com/nicksnyder/go-i18n/v2 v2.6.0/go.mod h1:88sRqr0C6OPyJn0/KRNaEz1uWorjxIKP7rUUcvycecE=


is both go-i18n/v2 v2.5.0 and go-i18n/v2 v2.6.0 required here?

vkagamlyk · 2026-01-05T20:14:48Z

gremlin-go/driver/client.go

-	request := makeBytecodeRequest(bytecode, client.traversalSource)
-	return client.gremlinClient.send(&request)
+// submitGremlinLang submits GremlinLang to the server to execute and returns a ResultSet.
+// TODO test and update when connection is set up


is there jira for this todo?

Cole-Greer · 2026-01-07T00:46:58Z

gremlin-go/driver/client.go

+// submitBytecode submits Bytecode to the server to execute and returns a ResultSet.
+// TODO remove
+//func (client *Client) submitBytecode(bytecode *Bytecode) (ResultSet, error) {
+//	client.logHandler.logf(Debug, submitStartedBytecode, *bytecode)
+//	request := makeBytecodeRequest(bytecode, client.traversalSource)
+//	return client.httpProtocol.send(&request)
+//}


Can this be removed now?

Cole-Greer · 2026-01-07T00:53:15Z

gremlin-go/driver/connection_test.go

 	testBasicAuthAuthInfo := getBasicAuthInfo()
 	testBasicAuthTlsConfig := &tls.Config{InsecureSkipVerify: true}

+	// this test is used to test the ws->http POC changes via manual execution with a local TP 4.0 gremlin server running on 8182


What's the plan for this test? It looks like it's mostly setup for manual debugging. Is the intention to keep it or will it be cleaned up or removed at a later date?

Cole-Greer · 2026-01-07T00:59:34Z

gremlin-go/driver/driverRemoteConnection.go

-	return driver.submitBytecode(bc)
-}
+// TODO remove
+// submitBytecode sends a Bytecode traversal to the server.


Can this be removed now?

Cole-Greer · 2026-01-07T01:11:31Z

gremlin-go/driver/gValue.go

+
+// GValue is a variable or literal value that is used in a Traversal. It is composed of a key-value pair where the key
+// is the name given to the variable and the value is the object that the variable resolved to.
+type GValue interface {


I'm not sure it's necessary to have an interface for GValue with accessor methods. I think we could get away with capitalizing the gValue struct type and allowing users to directly interact with it. I wouldn't expect there is much need for multiple implementations of the interface.

Cole-Greer · 2026-01-07T01:14:11Z

gremlin-go/driver/graphTraversalSource.go

-	return gts.bytecode
-}
+// TODO remove
+//func (gts *GraphTraversalSource) GetBytecode() *Bytecode {


Is this going to be replaced with a new GetGremlinLang() method?

Cole-Greer · 2026-01-07T01:40:57Z

gremlin-go/driver/gremlinlang.go

+		if math.IsNaN(float64(v)) {
+			return "NaN", nil
+		}
+		if math.IsInf(float64(v), 1) {
+			return "Infinity", nil
+		}
+		if math.IsInf(float64(v), -1) {
+			return "-Infinity", nil
+		}


This is definitely out of scope for this PR, but its occurring to me that we are losing the float 32 type for infinities and NaNs. Seems like a minor gap in the grammar which we may want to address.

Cole-Greer · 2026-01-07T01:47:23Z

gremlin-go/driver/gremlinlang.go

+	case time.Time:
+		return fmt.Sprintf("datetime(\"%v\")", v.Format(time.RFC3339)), nil
+	case cardinality, column, direction, operator, order, pick, pop, barrier, scope, t, merge, gType:
+		name := reflect.ValueOf(v).Type().Name()


It's unfortunate that we need to use reflection here. Definitely out of scope for this PR but we might want to revisit the design of our "pseudo-enums" and see if there's anything better.

Cole-Greer · 2026-01-07T01:48:33Z

gremlin-go/driver/gremlinlang.go

+		return fmt.Sprintf("%s.%s", strings.ToUpper(name), v), nil
+	case *Vertex:
+		id, _ := gl.argAsString(v.Id)
+		return fmt.Sprintf("new ReferenceVertex(%s,\"%s\")", escapeQuotes.Replace(id), escapeQuotes.Replace(v.Label)), nil


Are there tests for this? ReferenceVertex should not be present in the grammar.

Cole-Greer · 2026-01-07T01:56:32Z

gremlin-go/driver/gremlinlang_test.go

 				return g.V("44").ValueMap().With(WithOptions.Tokens, WithOptions.Labels)
 			},
-			equals: "g.V('44').valueMap().with(WithOptions.tokens,WithOptions.labels)",
+			equals: "g.V(\"44\").valueMap().with(\"~tinkerpop.valueMap.tokens\",2)",


The WithOptions in this and following cases don't look right, the grammar should parse the enums directly.

Suggested change

equals: "g.V(\"44\").valueMap().with(\"~tinkerpop.valueMap.tokens\",2)",

equals: "g.V(\"44\").valueMap().with(WithOptions.tokens,WithOptions.labels)",

Cole-Greer · 2026-01-07T02:04:22Z

gremlin-go/driver/traversal.go

 	UnscaledValue *big.Int
 }

+func (bd *BigDecimal) Value() *big.Float {


It would be nice if we could get rid of our BigDecimal type and allow users to directly use the native big.Float type

xiazcy and others added 2 commits January 2, 2026 13:14

update strategy config test

60a6887

vkagamlyk reviewed Jan 5, 2026

View reviewed changes

Cole-Greer reviewed Jan 7, 2026

View reviewed changes

	equals: "g.V(\"44\").valueMap().with(\"~tinkerpop.valueMap.tokens\",2)",
	equals: "g.V(\"44\").valueMap().with(WithOptions.tokens,WithOptions.labels)",

Go GLV replace Bytecode with GremlinLang & update serialization to GraphBinary 4 #3292

Are you sure you want to change the base?

Go GLV replace Bytecode with GremlinLang & update serialization to GraphBinary 4 #3292

Uh oh!

Conversation

xiazcy commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xiazcy commented Jan 5, 2026 •

edited

Loading